Added support to build and run UI only apps. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzraho
requested changes
Feb 11, 2020
scripts/deploy.actions.js
Outdated
| @@ -39,52 +39,54 @@ class DeployActions extends BaseScript { | |||
| * @memberof DeployActions | |||
| */ | |||
| async run (args = [], deployConfig = {}) { | |||
| const taskName = 'Deploy actions' | |||
| this.emit('start', taskName) | |||
| if (this.config.app.hasBackend) { | |||
There was a problem hiding this comment.
same comment here do like https://github.com/adobe/aio-app-scripts/blob/master/scripts/deploy.ui.js#L29
| @@ -127,10 +127,10 @@ class ActionServer extends BaseScript { | |||
| if (hasFrontend) { | |||
There was a problem hiding this comment.
also if not hasBackend we don't want to build & deploy actions + don't need to start the openwhisk server
moritzraho
requested changes
Feb 21, 2020
There was a problem hiding this comment.
@sandeep-paliwal almost LGTM, just let's make sure that we do not start the openwhisk server
I would replace the
if (local) {
... runs openwhisk local jar ...
}
if (backend){
...
}
if (frontend) {
...
}
with
if (backend) {
if (local) {
.. runs local ow ..
}
...
}
if (frontend) {
...
}
|
this has failing tests, and now merge conflicts also. |
|
@purplecabbage I will update the PR |
moritzraho
requested changes
Mar 5, 2020
There was a problem hiding this comment.
@sandeep-paliwal two comments on top:
- undeploy actions is missing the hasBackend check, so it fails with an ugly message
aio app runshowsℹ using remote actionseven if there are no actions
Fixed error for underloy cmd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aio commands used to error out when UI only apps were run.
Made sure all action dependencies for their build and deploy only are called if manifest file is present.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
create UI only app from CLI. Try out aio app run command.
Screenshots (if appropriate):
Types of changes
Checklist: